Allow redirect to MagicLink after Invalid Validation Code #5150

akshayasalvi · 2021-09-08T23:51:57Z

@chiragsalian Can you please review?

Details

Show link expired message and allow resending the magic link

Fixed Issues

$ #4737

Tests

Tested by setting a password for expired tokens
Tested by invalid logins without user email

QA Steps

Go to the login page and enter the email/phone
Select Forgot option
Visit the received magic link. It should have a accountId and validationCode new.expensify.com/<accountId>/<code>
Example URL : http://localhost:8080/setpassword/10504929/FGVGEKKUJ
Update the code to any invalid code.
Enter the password
It should redirect to the magic link page with the updated message

Tested On

Screenshots

Web

v2

Mobile Web

Desktop

iOS

Android

akshayasalvi · 2021-09-08T23:57:31Z

Lint error as the PR is WIP and I've added some console to test

chiragsalian · 2021-09-09T01:00:02Z

Moving your question posted here. Since its more technical i think it will be better discussed here.

So this part,

After the redirect, I can see in the console that only showResendValidationLinkForm is true yet it doesn't show the MagicLink page. It shows the Password page only. Once I do a refresh from the address bar it shows the magic link page.

I tested your code. So firstly i don't see where you're doing the redirect. For example here is the url i used - http://localhost:8080/setpassword/10/DWGZCFRKT. When i entered the new password i noticed the API failed which is expected. After this there are two parts to address that i believe your code hasn't captured,

On this line this.props.credentials.login has no value and hence showResendValidationLinkForm will remain undefined.
The URL contiunes to stay with setpassword/10/DWGZCFRKT so the setPassword component is not unmounted and hence you're not getting the desired affect.

To solve these,
For 1: We'll firstly the API should return email. It currently does not. I'll push up a PR so that it returns email. But after that you need to set credentials.login after this line.
For 2: At the end of this block you'll need to do a redirect to unmount setPassword i.e., you should do Navigation.navigate(ROUTES.HOME);.

Let me know if those make sense.

akshayasalvi · 2021-09-09T01:06:25Z

Hi, Thanks for the response.

this.props.credentials.login has no value
Yeah, I am guessing it is because I was manually hitting setpassword it caused an issue.

To solve these,
For 1: We'll firstly the API should return email. It currently does not. I'll push up a PR so that it returns email. But after that you need to set credentials.login after this line.

Okay I'll update the credentials in Onyx. But one addition would be if you see currently it is going to the catch block. If you're going to send the email in the response you'll have to probably send success along with the jsonCode like the other APIs, right?

For 2: At the end of this block you'll need to do a redirect to unmount setPassword i.e., you should do Navigation.navigate(ROUTES.HOME);.

I did put Navigation.navigate in the catch block. But removed it to see if it was causing an issue. I thought calling the same route was causing it.

chiragsalian · 2021-09-09T01:40:01Z

But one addition would be if you see currently it is going to the catch block. If you're going to send the email in the response you'll have to probably send success along with the jsonCode like the other APIs, right?

No i don't have to send success just to send data. If you check response in catch block even now it has data. It just doesn't have the email which we should pass so you can use it.

akshayasalvi · 2021-09-09T01:45:04Z

You're right. Just saw. Makes sense. Thanks 👍

akshayasalvi · 2021-09-09T15:07:51Z

Hi @chiragsalian Let me know once the API is ready and I'll finish this today.

chiragsalian · 2021-09-10T01:19:15Z

Sorry, i didn't get to this today, but its on my plate to work on for tomorrow. Once i create the return param i can test it out with your PR but even if my code is merged tomorrow it would take 3 business days before its live and we can merge your PR. Just letting you know.

akshayasalvi · 2021-09-10T17:05:37Z

Sorry, i didn't get to this today, but its on my plate to work on for tomorrow. Once i create the return param i can test it out with your PR but even if my code is merged tomorrow it would take 3 business days before its live and we can merge your PR. Just letting you know.

Should I then assume that I receive the param and then update this PR so that it is easier for you to test?

chiragsalian · 2021-09-10T17:51:11Z

Should I then assume that I receive the param and then update this PR so that it is easier for you to test?

Yes definitely.

chiragsalian · 2021-09-10T22:43:38Z

I've made the change. Just so you know, in the catch statement if you're passing response. The email will be under response.data.email. I'll put out my code for review now. I expect it would be live for you to use on tuesday or wednesday. You can still code out the remaining pieces and we can review it so its ready to merge whenever my code is live.

akshayasalvi · 2021-09-11T03:19:14Z

Thanks I’ll update the code over the weekend.

…on-code-expiry

akshayasalvi · 2021-09-12T04:42:29Z

@chiragsalian I've updated the PR and manually tested the flow.

I've got one query though. The data param in the API response looks like an array but you've mentioned the key as response.data.email. So can you confirm the key once and then accordingly I'll update if required.

marcaaron · 2021-09-13T18:09:06Z

src/languages/es.js

@@ -344,6 +344,7 @@ export default {
        linkHasBeenResent: 'El enlace se ha reenviado',
        weSentYouMagicSignInLink: ({loginType}) => `Hemos enviado un enlace mágico de inicio de sesión a tu ${loginType}.`,
        resendLink: 'Reenviar enlace',
+        validationCodeFailedMessage: 'Parece que ha habido un error con tu enlace de validación. O bien el enlace de validación ha caducado, o su cuenta no existe.',


Just checking but did we run this translation past the Español team here at Expensify?

I feel like this copy wasn't confirmed. I reached out to the Español team and will let you guys know once i get copy confirmation.

The copy i received that we should use here is,

Parece que hubo un error con el enlace de validación. El enlace de validación ha caducado o tu cuenta no existe.

marcaaron · 2021-09-13T18:12:59Z

src/libs/actions/Session.js

@@ -126,6 +127,7 @@ function fetchAccountDetails(login) {
                    validated: response.validated,
                    closed: response.isClosed,
                    forgotPassword: false,
+                    validationCodeFailedMessage: null,


I'm not sure if this is the best way to handle these errors.

It looks like this will set the translation key for the error message?

I think it would be better to make this an object with a key of errors rather than have an object key per error. We are using a similar strategy in other forms so it would be a good idea to align on this and keep things consistent.

Spoke to marc a bit about this let's actually change this to a boolean validateCodeExpired: false here and not save translations keys.

marcaaron · 2021-09-13T18:14:21Z

src/libs/actions/Session.js

-        .finally(() => {
+        }).catch((errResponse) => {
+            const login = lodashGet(errResponse, 'data.email', null);
+            Onyx.merge(ONYXKEYS.ACCOUNT, {validated: false, validationCodeFailedMessage: 'resendValidationForm.validationCodeFailedMessage'});


When we display the error in the UI then we can use the correct translation key. I think there's no reason to persist it in device storage.

WRt to my previous comment, this now becomes validateCodeExpired: true here.

marcaaron · 2021-09-13T18:15:39Z

src/pages/signin/ResendValidationForm.js

@@ -63,7 +66,7 @@ class ResendValidationForm extends React.Component {
     */
    validateAndSubmitForm() {
        this.setState({
-            formSuccess: this.props.translate('resendValidationForm.linkHasBeenResent'),
+            formSuccess: this.props.translate(''),


Why are we translating a key of '' ... ?

marcaaron · 2021-09-13T18:18:45Z

src/pages/signin/ResendValidationForm.js

@@ -34,6 +34,9 @@ const propTypes = {
        closed: PropTypes.bool,
    }),

+    /** Title to be shown in the form */
+    titleMessage: PropTypes.string.isRequired,


There are a couple of issues with this:

We are not passing a message here we are passing a translation key

It would be better to pass along something like an errors object and then have the form itself define the translation keys to use.

Discussed with marc on this one. So yeah we agree this variable name does not represent what it is. In your code its translation keys and not a message so its confusing.

Let's translate in the parent component so that this remains titleMessage and hence keeps the child component clean.

marcaaron · 2021-09-13T18:22:43Z

src/pages/signin/SignInPage.js

+            ? ''
+            : this.props.translate(`welcomeText.${showPasswordForm ? 'phrase4' : 'phrase1'}`);
+
+        const resendLinkTitleMessage = this.props.account.validationCodeFailedMessage ?? 'resendValidationForm.weSentYouMagicSignInLink';


AFAIK we are not widely using the null coalescence operator in our JS code and standardize on lodashGet() for many things. This should be something like

lodashGet(this.props.account, 'validationCodeFailedMessage', 'resendValidationForm.weSentYouMagicSignInLink')

But as mentioned elsewhere ... I don't think it's correct to store the translation key.

chiragsalian

the data param in the API response looks like an array but you've mentioned the key as response.data.email

Its an object. So your code i.e., lodashGet(errResponse, 'data.email', null); is good.

chiragsalian · 2021-09-14T01:45:19Z

src/languages/es.js

@@ -344,6 +344,7 @@ export default {
        linkHasBeenResent: 'El enlace se ha reenviado',
        weSentYouMagicSignInLink: ({loginType}) => `Hemos enviado un enlace mágico de inicio de sesión a tu ${loginType}.`,
        resendLink: 'Reenviar enlace',
+        validationCodeFailedMessage: 'Parece que ha habido un error con tu enlace de validación. O bien el enlace de validación ha caducado, o su cuenta no existe.',


I feel like this copy wasn't confirmed. I reached out to the Español team and will let you guys know once i get copy confirmation.

chiragsalian · 2021-09-14T01:46:46Z

src/libs/actions/Session.js

@@ -126,6 +127,7 @@ function fetchAccountDetails(login) {
                    validated: response.validated,
                    closed: response.isClosed,
                    forgotPassword: false,
+                    validationCodeFailedMessage: null,


Spoke to marc a bit about this let's actually change this to a boolean validateCodeExpired: false here and not save translations keys.

chiragsalian · 2021-09-14T01:47:26Z

src/libs/actions/Session.js

-        .finally(() => {
+        }).catch((errResponse) => {
+            const login = lodashGet(errResponse, 'data.email', null);
+            Onyx.merge(ONYXKEYS.ACCOUNT, {validated: false, validationCodeFailedMessage: 'resendValidationForm.validationCodeFailedMessage'});


WRt to my previous comment, this now becomes validateCodeExpired: true here.

chiragsalian · 2021-09-14T01:49:29Z

src/pages/signin/ResendValidationForm.js

@@ -34,6 +34,9 @@ const propTypes = {
        closed: PropTypes.bool,
    }),

+    /** Title to be shown in the form */
+    titleMessage: PropTypes.string.isRequired,


Discussed with marc on this one. So yeah we agree this variable name does not represent what it is. In your code its translation keys and not a message so its confusing.

Let's translate in the parent component so that this remains titleMessage and hence keeps the child component clean.

chiragsalian · 2021-09-14T01:50:14Z

src/pages/signin/ResendValidationForm.js

@@ -84,7 +87,7 @@ class ResendValidationForm extends React.Component {
            <>
                <View>
                    <Text>
-                        {this.props.translate('resendValidationForm.weSentYouMagicSignInLink', {
+                        {this.props.translate(this.props.titleMessage, {


As per this comment. let's translate in the parent.

akshayasalvi · 2021-09-14T02:53:35Z

Thanks @marcaaron and @chiragsalian for the comments. I’ll update the PR by tomorrow.

akshayasalvi · 2021-09-15T18:54:04Z

@chiragsalian PR Updated

chiragsalian

Left some minor comments, Rest of the code looks good to me and works well.

chiragsalian · 2021-09-16T00:16:14Z

src/pages/signin/SignInPage.js

+
+        const validateCodeExpired = lodashGet(this.props.account, 'validateCodeExpired', false);
+
+        const resendLinkTitleMessage = this.props.translate(`resendValidationForm.${validateCodeExpired ? 'validationCodeFailedMessage' : 'weSentYouMagicSignInLink'}`,


i think there is too much here. This line is not very readable and it took me a while to understand why loginType is there for validationCodeFailedMessage (took me a while to realize its not needed for validationCodeFailedMessage but is used just for weSentYouMagicSignInLink)

I personally feel this would be easier read if written like so,

let resendLinkTitleMessage = ''; if (validateCodeExpired) { resendLinkTitleMessage = this.props.translate('resendValidationForm.validationCodeFailedMessage'); } else if (showResendValidationLinkForm) { resendLinkTitleMessage = this.props.translate('resendValidationForm.weSentYouMagicSignInLink', { loginType: (Str.isSMSLogin(this.props.credentials.login) ? this.props.translate('common.phoneNumber').toLowerCase() : this.props.translate('common.email')).toLowerCase(), }); }

Okay, thanks. I'll update and raise the PR. Somewhere earlier I had seen that we prefer ternary operator over if-else block.

Yeah, normally we prefer ternary. This situation is a little different though, with the ternary the operations and arguments involved become hard to follow so I feel like if-else is a lot cleaner here.

chiragsalian · 2021-09-16T00:18:29Z

src/languages/en.js

@@ -344,6 +344,8 @@ export default {
        linkHasBeenResent: 'Link has been re-sent',
        weSentYouMagicSignInLink: ({loginType}) => `We've sent a magic sign in link to your ${loginType}.`,
        resendLink: 'Resend link',
+        validationCodeFailedMessage: 'It looks like there was an error with your validation link. Either the validation link has expired, or your account does not exist.',
+


remove unnecessary line break here.

src/libs/actions/Session/index.js

marcaaron · 2021-12-20T19:02:18Z

What's the status here?

marcaaron · 2021-12-23T06:41:20Z

Haven't got a response here so thinking maybe we must consider this PR abandoned.
Happy to take over and finish this one up if that works for you @chiragsalian - it was pretty close.

akshayasalvi · 2021-12-23T08:20:08Z

@marcaaron Sorry I somehow missed this one. I've responded to your comment above.

…on-code-expiry # Conflicts: # src/components/WelcomeText.js # src/pages/signin/SignInPage.js

akshayasalvi · 2021-12-23T09:04:01Z

@marcaaron PR updated

marcaaron · 2021-12-23T22:03:14Z

src/libs/actions/Session/index.js

-            Onyx.merge(ONYXKEYS.ACCOUNT, {error: Localize.translateLocal('setPasswordPage.accountNotValidated')});
+            const login = lodashGet(response, 'data.email', null);
+            Onyx.merge(ONYXKEYS.ACCOUNT, {
+                validated: true, accountExists: true, validateCodeExpired: true, error: Localize.translateLocal('setPasswordPage.accountNotValidated'),


Does the above change make sense?

It makes sense as a quick solution. However, based on the full conversation in this PR so far - it isn't the one we want and will introduce inconsistency with how we handle errors.

Please try to ask clarifying questions before proposing alternatives, because I'm not sure if we are seeing eye to eye on the problem. I will try to be as specific as possible so we can move on from this PR...

The issue is with setting validated: true.

It seems the only reason we need to set this here is so that the correct error will show here:

App/src/pages/signin/ResendValidationForm.js

Lines 90 to 105 in 361f097

const isNewAccount = !this.props.account.accountExists;

const isOldUnvalidatedAccount = this.props.account.accountExists && !this.props.account.validated;

const isSMSLogin = Str.isSMSLogin(this.props.credentials.login);

const login = isSMSLogin ? this.props.toLocalPhone(Str.removeSMSDomain(this.props.credentials.login)) : this.props.credentials.login;

const loginType = (isSMSLogin ? this.props.translate('common.phone') : this.props.translate('common.email')).toLowerCase();

let message = '';

if (isNewAccount) {

message = this.props.translate('resendValidationForm.newAccount', {

login,

loginType,

});

} else if (isOldUnvalidatedAccount) {

message = this.props.translate('resendValidationForm.unvalidatedAccount');

} else if (this.props.account.validateCodeExpired) {

message = this.props.translate('resendValidationForm.validationCodeFailedMessage');

The isOldUnvalidatedAccount variable needs to be false and I suspect that's only reason we are setting it to true. But it is not the correct state for the account. We must change the logic that shows the errors not the state of the account.

src/libs/actions/Session/index.js

…on-code-expiry

akshayasalvi · 2021-12-28T12:15:50Z

@marcaaron I've updated the PR. Hope this does make sense. Thanks for being patient on this one. It has gone through multiple iterations and is a lot different from the initial changes. Appreciate your help. Will make any changes if we're still on a different page.

marcaaron

Sorry @akshayasalvi, doesn't seem like my feedback was understood so I suggested the changes we need to make.

src/pages/signin/ResendValidationForm.js

akshayasalvi · 2022-01-03T18:10:54Z

@marcaaron @chiragsalian Is there anything else that needs to be done in this PR from my side?

chiragsalian · 2022-01-03T18:11:46Z

Nope, not at the moment. I was off a few days for the new years but i'll test/review your PR today 👍

chiragsalian

Code LGTM and works well. I'm going to merge this PR since it would unblock others waiting on this functionality.
I've left one NAB to address so can you make a follow up for it.

Additionally the screenshot does not match what actually happens so can you update it. The copy between the two are different. This is the copy your PR will actually give,

chiragsalian · 2022-01-03T19:16:33Z

src/languages/en.js

        phrase2: 'Money talks. And now that chat and payments are in one place, it\'s also easy.',
        phrase3: 'Your payments get to you as fast as you can get your point across.',
-        phrase4: 'Welcome back to the New Expensify! Please enter your password.',
+        welcomeBack: 'Welcome back to the New Expensify! Please enter your password.',


I'm not a fan of these names, especially when i read it in code like so,

`welcomeText.${showPasswordForm ? 'welcomeBack' : 'welcome'}`

Since its confusing to me why if showPasswordForm is true do we want welcomeBack versus welcome. Plus variables should be named after their intention of like what they store and not their parent/class names.

So in this case welcome, wants the phone or email so i would suggest - enterPhoneOrEmail. This becomes welcomeText.enterPhoneOrEmail which is a lot cleaner as welcomeText.welcome is redundant.
As for welcomeBack, it wants the password so i would suggest - enterPassword.

So now the logic becomes,

`welcomeText.${showPasswordForm ? 'enterPassword' : 'enterPhoneOrEmail'}`

which is a lot more verbose and cleaner imo.

This is a NAB - not a blocker.

That's a good point. In general, feels like the names for these translation keys is a bit all over the place. Wondering if we can maybe come up with some standard guidance for how to name them and then get everyone to apply it in a consistent way?

Wondering if we can maybe come up with some standard guidance for how to name them and then get everyone to apply it in a consistent way?

Yes, love it.

OSBotify · 2022-01-04T01:53:20Z

🚀 Deployed to staging by @chiragsalian in version: 1.1.24-19 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

OSBotify · 2022-01-04T02:40:18Z

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

Allow redirect to MagicLink after Invalid Validation Code

b10f53f

akshayasalvi added 2 commits September 11, 2021 12:44

Merge branch 'main' of github-personal:akshayasalvi/App into validati…

0a6362e

…on-code-expiry

Added login handling along with navigation

a1ce081

akshayasalvi marked this pull request as ready for review September 12, 2021 04:17

akshayasalvi requested a review from a team as a code owner September 12, 2021 04:17

MelvinBot requested review from marcaaron and removed request for a team September 12, 2021 04:17

Updated default value to null

0ecd7f7

marcaaron requested a review from chiragsalian September 13, 2021 18:07

marcaaron assigned akshayasalvi Sep 13, 2021

marcaaron requested changes Sep 13, 2021

View reviewed changes

chiragsalian requested changes Sep 14, 2021

View reviewed changes

Changed translation key to flag and move translation to parent component

3f1ad9e

akshayasalvi requested a review from chiragsalian September 15, 2021 18:53

Added truthy check

745efbb

chiragsalian requested changes Sep 16, 2021

View reviewed changes

Added comment for login var

0bfaf85

akshayasalvi requested a review from marcaaron December 6, 2021 17:10

marcaaron reviewed Dec 6, 2021

View reviewed changes

src/libs/actions/Session/index.js Outdated Show resolved Hide resolved

akshayasalvi added 2 commits December 23, 2021 14:15

Merge branch 'main' of github-personal:akshayasalvi/App into validati…

361f097

…on-code-expiry # Conflicts: # src/components/WelcomeText.js # src/pages/signin/SignInPage.js

Updated comment and setting error null

b1ba7fa

marcaaron requested changes Dec 23, 2021

View reviewed changes

akshayasalvi added 2 commits December 27, 2021 22:27

Merge branch 'main' of github-personal:akshayasalvi/App into validati…

c51f126

…on-code-expiry

Removed the validate: true in setpassword

c11c337

akshayasalvi requested a review from marcaaron December 28, 2021 12:16

chiragsalian mentioned this pull request Dec 28, 2021

New user gets stuck on loading after clicking on Set Password button - reported by @adeel0202 #6890

Closed

marcaaron requested changes Dec 29, 2021

View reviewed changes

src/pages/signin/ResendValidationForm.js Outdated Show resolved Hide resolved

src/pages/signin/ResendValidationForm.js Outdated Show resolved Hide resolved

Reordered conditions for correct validateExpiry message

6180d9e

anthony-hull mentioned this pull request Dec 30, 2021

improve setPassword UX #6587

Merged

5 tasks

marcaaron approved these changes Dec 30, 2021

View reviewed changes

chiragsalian approved these changes Jan 3, 2022

View reviewed changes

chiragsalian merged commit e5a3f2c into Expensify:main Jan 3, 2022

marcaaron mentioned this pull request Jan 3, 2022

Fix inconsistent translation key naming #6990

Closed

botify mentioned this pull request Jan 4, 2022

[HOLD for payment 2022-01-11] [Network] No error messages shown to user when setpassword gets an error from the API #4737

Closed

OSBotify mentioned this pull request Jan 4, 2022

Deploy Checklist: New Expensify 2022-01-04 #7005

Closed

45 tasks

kavimuru mentioned this pull request Jan 4, 2022

Password setup - Message is different when redirected to the magic link page after entering invalid validation code #7030

Closed

marcaaron mentioned this pull request Apr 18, 2022

Remove unused code for setPassword() action #8680

Merged

45 tasks


		const validateCodeExpired = lodashGet(this.props.account, 'validateCodeExpired', false);

		const resendLinkTitleMessage = this.props.translate(`resendValidationForm.${validateCodeExpired ? 'validationCodeFailedMessage' : 'weSentYouMagicSignInLink'}`,

	const isNewAccount = !this.props.account.accountExists;
	const isOldUnvalidatedAccount = this.props.account.accountExists && !this.props.account.validated;
	const isSMSLogin = Str.isSMSLogin(this.props.credentials.login);
	const login = isSMSLogin ? this.props.toLocalPhone(Str.removeSMSDomain(this.props.credentials.login)) : this.props.credentials.login;
	const loginType = (isSMSLogin ? this.props.translate('common.phone') : this.props.translate('common.email')).toLowerCase();
	let message = '';

	if (isNewAccount) {
	message = this.props.translate('resendValidationForm.newAccount', {
	login,
	loginType,
	});
	} else if (isOldUnvalidatedAccount) {
	message = this.props.translate('resendValidationForm.unvalidatedAccount');
	} else if (this.props.account.validateCodeExpired) {
	message = this.props.translate('resendValidationForm.validationCodeFailedMessage');

Allow redirect to MagicLink after Invalid Validation Code #5150

Allow redirect to MagicLink after Invalid Validation Code #5150

Conversation

akshayasalvi commented Sep 8, 2021 • edited Loading

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

v2

Mobile Web

Desktop

iOS

Android

akshayasalvi commented Sep 8, 2021

chiragsalian commented Sep 9, 2021

akshayasalvi commented Sep 9, 2021

chiragsalian commented Sep 9, 2021

akshayasalvi commented Sep 9, 2021

akshayasalvi commented Sep 9, 2021

chiragsalian commented Sep 10, 2021

akshayasalvi commented Sep 10, 2021

chiragsalian commented Sep 10, 2021

chiragsalian commented Sep 10, 2021

akshayasalvi commented Sep 11, 2021

akshayasalvi commented Sep 12, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chiragsalian left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akshayasalvi commented Sep 14, 2021

akshayasalvi commented Sep 15, 2021

chiragsalian left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcaaron commented Dec 20, 2021

marcaaron commented Dec 23, 2021

akshayasalvi commented Dec 23, 2021

akshayasalvi commented Dec 23, 2021

Choose a reason for hiding this comment

akshayasalvi commented Dec 28, 2021

marcaaron left a comment

Choose a reason for hiding this comment

akshayasalvi commented Jan 3, 2022

chiragsalian commented Jan 3, 2022

chiragsalian left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Jan 4, 2022

OSBotify commented Jan 4, 2022

akshayasalvi commented Sep 8, 2021 •

edited

Loading